search

ITPNYU / booking-app

0 stars 2 forks source link

URGENT: BUG: Editing an approved booking request does not change its status in the booking tool. #469

Open nopivnick opened 1 month ago

nopivnick commented 1 month ago

to replicate:

  1. submit a request for rooms 221 & 222 that's longer than 4 hours (not auto-approve eligible)
  2. as a liaison, pre-approve the request
  3. as a final approver, approve the request
  4. as a user, edit the request to less than 4 hours, add equipment, and re-submit the request
  5. observe a request email notification is sent to the liaison but the status of the edited request does not change (it remains APPROVED and doesn't appear under Liaison » Bookings table).

expected behavior:

  1. submit a request for rooms 221 & 222 that's longer than 4 hours (not auto-approve eligible)
  2. as a liaison, pre-approve the request
  3. as a final approver, approve the request
  4. as a user, edit the request to less than 4 hours, add equipment, and re-submit the request
  5. the request should change status to REQUESTED and should appear under Liaison » Bookings table.
lucia-gomez commented 1 month ago

what deploy was this on? usually shouldn't matter but with all of the recent refactoring it could

nopivnick commented 1 month ago

@lucia-gomez it was on production.

lucia-gomez commented 1 month ago

ok i see the problem, trying to fix it