codecov-commenter
commented
6 months ago Codecov Report
Attention: Patch coverage is 78.05907% with 52 lines in your changes are missing coverage. Please review.
Project coverage is 81.89%. Comparing base (
c7f5e4b) to head (8845549). Report is 1 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #154 +/- ## ========================================== - Coverage 82.00% 81.89% -0.12% ========================================== Files 71 72 +1 Lines 3751 3744 -7 ========================================== - Hits 3076 3066 -10 - Misses 675 678 +3 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This changes
TTN(...)tottn(...)andrandomITensorNetwork(...)torandom_tensornetwork(...)(to be closer torandom_mpsandrandom_ttn).@b-kloss this will probably be breaking for you. The reasoning for this is that we will likely get rid of the
TTNtype sottn(...)is more "forward looking", i.e. in the future it can construct anITensorNetwork. Additionally,randomITensorNetworkdoesn't follow the naming convention in Julia that functions that aren't constructors should be all lower case.EDIT: I also moved
ising_networkand Hamiltonian constructors likeising,heisenberg, etc. to submodulesModelNetworksandModelHamiltonians, which is also breaking if those were being accessed with the notationITensorsNetworks.isingorusing ITensorsNetworks: ising. Now they should be accessed withusing ITensorNetworks.ModelHamiltonians: isingorITensorNetworks.ModelHamiltonians: ModelHamiltoniansandModelHamiltonians.ising.