ITotalJustice / notorious_beeg

gba emulator written in c++23
https://notorious-beeg.netlify.app/
GNU General Public License v3.0
41 stars 4 forks source link

sound "clicking" in nes classic games #47

Closed ITotalJustice closed 2 years ago

ITotalJustice commented 2 years ago

this only happens in scheduler build.

could be either timer events are firing too late/early or fifo dma is late/early.

ITotalJustice commented 2 years ago

related to #54

ITotalJustice commented 2 years ago

see #54 for the bug, and how i fixed it.

in zelda 1, this caused the audio pop https://github.com/ITotalJustice/notorious_beeg/blob/fc0ea56583616fef7679e530f6ec74571a5949e3/src/core/arm7tdmi/arm7tdmi.cpp#L107

and this caused gfx being slightly wrong https://github.com/ITotalJustice/notorious_beeg/blob/fc0ea56583616fef7679e530f6ec74571a5949e3/src/core/arm7tdmi/arm7tdmi.cpp#L404