[WEB] chrome mobile loses focus after SDL_ShowMessageBox - Githubissues

ITotalJustice / notorious_beeg

gba emulator written in c++23

https://notorious-beeg.netlify.app/

GNU General Public License v3.0

41 stars 4 forks source link

[WEB] chrome mobile loses focus after SDL_ShowMessageBox #91

Open ITotalJustice opened 2 years ago

ITotalJustice commented 2 years ago

to reproduce:

open emu in chrome mobile
press loadstate
notice the error because it failed to loadstate (expected)
press okay on the alert
em now fires EMSCRIPTEN_EVENT_BLUR, sdl gets it and now fires SDL_WINDOWEVENT_FOCUS_LOST.
focus is never returned.

i think it only happens in chrome mobile. it works on firefox and safari ios, as well as desktop and desktop browsers.

haven't looked into how emscripten decides to fire a focus event yet. will need to find a fix and pr it.

useful links:

SDL_ShowMessageBox does a simple js alert https://github.com/libsdl-org/SDL/blob/00452e47fa022314b4c21af2d4e5b63a53f89b8f/src/video/SDL_video.c#L4591
sdl basically wraps around emscripten html wapper api https://github.com/libsdl-org/SDL/blob/10e1ef00e29479f3ac0ba4d0bf3e0083fca8b2a0/src/video/emscripten/SDL_emscriptenevents.c#L442.

note related to the issue, but the variable name for the event data is wrong, copy and paste error https://github.com/libsdl-org/SDL/blob/10e1ef00e29479f3ac0ba4d0bf3e0083fca8b2a0/src/video/emscripten/SDL_emscriptenevents.c#L432