search

Icinga / chef-icinga2

Icinga 2 Chef Cookbook
https://supermarket.chef.io/cookbooks/icinga2
Apache License 2.0
41 stars 55 forks source link

Split cookbook #293

Closed vills closed 7 years ago

vills commented 7 years ago

Currently, cookbook logic is very complex. It is hard to maintain it.

How about to split this cookbook to different cookbooks? Let's say, cookbook for:

vkhatri commented 7 years ago

IMHO, splitting icingaweb2 or classic-ui recipes to its own cookbook should not make much of the difference. They are single recipe resource collection but have the dependency on icinga2 packages and services.

However, we can certainly merge recipes server_object_* into server_objects. Perhaps, we can split recipe server_pnp to its own wrapper cookbook.

Please let me know your thoughts. I do agree on the complexity of the cookbook.

I think updating the cookbook for Chef 13 may bring some simplicity.

vills commented 7 years ago

As for my opinion, icinga(-core) and icingaweb is different services, that should be placed in different cookbooks. Maybe there is no need to split icingaweb2 and classic-ui, but sure core and web should be splitted.

We can return back here after updating cookbook for Chef 13.

vkhatri commented 7 years ago

SGTM

vkhatri commented 7 years ago

I have started working on splitting the cookbook. Will create issues shortly.

vkhatri commented 7 years ago

Local testing completed:

Pending:

vkhatri commented 7 years ago

New cookbooks.

dnsmichi commented 7 years ago

If you need an additional opinion - drop the classicui cookbook. The config files and meta packages for that are gone in v2.8. icingaweb2 is the main developed UI :)

Thanks for your hard work in this 👍

vkhatri commented 7 years ago

Sure. I have already created and tested icinga2classicui chef cookbook locally.

IMHO, we should keep cookbook chef-icinga2classicui for now in favor of the community.

We can deprecate it post icinga2 v2.8 release.

Let me know your thoughts.

vkhatri commented 7 years ago

Never mind, v2.8 is out.

vkhatri commented 7 years ago

Created different cookbooks for icingaweb2, icinga2client, and icinga2repo.

Closing.