search

IgnitionModuleDevelopmentCommunity / Kafka

Kafka extension for Ignition
Apache License 2.0
2 stars 4 forks source link

Update Kafka.java #3

Closed jklingm closed 4 years ago

jklingm commented 4 years ago

Added the records field for Kafka headers

Kevin-McClusky commented 4 years ago

Looks great, easy merge, and definitely makes sense to include the headers in there. Thanks for the contribution!

Kevin-McClusky commented 4 years ago

Unfortunately, I had to revert this. The headers are an object that's not serializable, so it was breaking all requests from the client/designer to the Kafka functions. If you'd like the headers to be part of the return from the functions, feel free to switch the headers object into a serializable format (possibly putting strings into a HashMap), test by calling this from the designer or client, and then submit a new PR. Thanks!

https://github.com/IgnitionModuleDevelopmentCommunity/Kafka/blob/0f785bd12b1871c0c464da3b9b8cbe128d74e74c/kafka-gateway/src/main/java/org/ignitionmdc/apache/kafka/Kafka.java#L178