Indefinite spinner under certain conditions for cohort selection

ImagingDataCommons / IDC-WebApp

Web Application front end for IDC (CORE REPO)

Apache License 2.0

6 stars 2 forks source link

Indefinite spinner under certain conditions for cohort selection #1386

Open fedorov opened 4 months ago

fedorov commented 4 months ago

To reproduce, select the items in the screen. Per @s-paquette it is a zero count exception.

pgundluru commented 3 months ago

Another instance

pgundluru commented 2 months ago

In this case, I selected all non Zero collections and one Zero count filter in body part

G-White-ISB commented 2 months ago

My understanding is that the condition producing the indefinite spinner state is that the filters are selected which return an empty cohort. In that case there are errors generated client side in the ajax calls to update the facet counts and populate the tables. I have updated code in the expr branch to handle the errors gracefully for generating the facet counts and populating the tables. So these conditions should no longer produce this state. I am not sure if manifest downloads may still cause a problem

s-paquette commented 2 weeks ago

@fedorov @pgundluru Now available for testing. This will:

Automatically check 'hide zeros' for all 3 categories that have it as an option when the page loads
If a user selects a filter which brings the total to zero, they will receive an alert message letting them know
If a user selects a filter which brings the total to zero, the 'download images' and 'save cohort' buttons are disabled.

pgundluru commented 4 days ago

The following are tested in test tier Automatically checks zeros - Success Select filters and see a message - Success Download images and save cohort are disabled - success