search

ImagingDataCommons / IDC-WebApp

Web Application front end for IDC (CORE REPO)
Apache License 2.0
6 stars 2 forks source link

Single-series v3 URL needs to be updated #1407

Open fedorov opened 2 months ago

fedorov commented 2 months ago

The template URL for series selection should use SeriesInstanceUIDs, not singular SeriesInstanceUID.

So this URL (which does not select series)

https://viewer.imaging.datacommons.cancer.gov/v3/viewer/?StudyInstanceUIDs=1.2.840.113654.2.55.327670372562599702205432127692146974562&SeriesInstanceUID=1.2.840.113654.2.55.79318439085250760439172236218713769408

should become

https://viewer.imaging.datacommons.cancer.gov/v3/viewer/?StudyInstanceUIDs=1.2.840.113654.2.55.327670372562599702205432127692146974562&SeriesInstanceUIDs=1.2.840.113654.2.55.79318439085250760439172236218713769408

fedorov commented 2 months ago

ohif folks confirmed it was a recent breaking change on their part https://docs.ohif.org/migration-guide/from-3p7-to-3p8#studyinstanceuid-in-the-url-param

fedorov commented 2 months ago

Legacy selection option has been added in https://github.com/OHIF/Viewers/pull/4346, we will need to update the viewer to get this, but no need to change the app.

fedorov commented 2 months ago

Per discussion, let's just add the missing "s".