ImagingDataCommons / IDC-WebApp

Web Application front end for IDC (CORE REPO)
Apache License 2.0
6 stars 2 forks source link

Portal footer is no compliant with NCI requirements #449

Closed ulrikew closed 3 years ago

ulrikew commented 3 years ago

The MVP portal footer is not compliant with HHS/NIH/NCI requirements. For guidance see the footer of PDC and GDC. image

fedorov commented 3 years ago

NCI-Digital-Style-Guide_8.pdf for the footer requirements.

fedorov commented 3 years ago

Example how external links are handled on one of the NIH sites: https://www.nih.gov/institutes-nih/nih-office-director/office-communications-public-liaison

image

ulrikew commented 3 years ago

Looks like a good way to solve the problem. cancer.gov links to this website when users click on the little arrow symbol next to the link that brings them to the external site. https://www.cancer.gov/policies/linking Maybe all that needs to be done is place the icon next to the Discourse and GitBook link and link the icon to https://www.cancer.gov/policies/linking which would remove the need for a pop-up window that the user has to close.

mitianisb commented 3 years ago

@fedorov @ulrikew @wlongabaugh Thanks for the information above. I have been working on this together with #448 and #458. Here is the latest of the updated site footer and header. Please let me know of any feedback. Thank you!

IDC_SiteFooter_ExternalLink

fedorov commented 3 years ago

@mitianisb I like all the information you included, but I think the formatting could be refined. I suggest we take the items under "MORE INFORMATION", and put those in a single line, separated by | (the same as in the line next to the last one). Then everything from the text on the right hand side is center-justified, and located under the first line. Then we take the items under "FOLLOW US" and again put those in a single line under. Does this make sense?

ulrikew commented 3 years ago

@mitianisb Much improved! Please review the NCI Digital Style Guide again. The footer section on page 3 states that the Policies links are required (labeled as 5d). What do you think about having a Contact Us section that links to the IDC email and repeats the link to Discourse? Keyvan had suggested/requested to have a link to the email on the home page.

mitianisb commented 3 years ago

@ulrikew Thanks for the reminders! I have added them in both versions below. In the column version I tried add Contact Us section but it made the columns crowded. So I put them under "More Information" instead.

@fedorov Thanks for suggestion. I thought about it when I started, but worried the current footer text have too many rows will make it look busy. I implemented it now and made both version to compare below.

With columns: IDC_Footer_ColumnsVersion

With no columns: IDC_Footer_NoColumnVersion

mitianisb commented 3 years ago

@fedorov @ulrikew How do you feel about the latest version? Which version do we want to proceed? Thanks!

fedorov commented 3 years ago

My preference is the one with single column.

ulrikew commented 3 years ago

I don't have a strong preference. Either works for me (until somebody tells us otherwise). Andrey, how do you feel about deleting the word consortium from the funding source sentence?

fedorov commented 3 years ago

Sure, let's remove "consortium".

mitianisb commented 3 years ago

Ok, I will proceed with the one with a single column and remove 'consortium'. @fedorov Can you let me know which IDC email address I should link to the contact us button? Thanks!

fedorov commented 3 years ago

support@canceridc.dev

fedorov commented 3 years ago

Maybe all that needs to be done is place the icon next to the Discourse and GitBook link and link the icon to https://www.cancer.gov/policies/linking which would remove the need for a pop-up window that the user has to close.

@ulrikew we believe we should have the icon next to the external (non-gov) websites, and when the user clicks those external links, they should be warned by the popup.

mitianisb commented 3 years ago

@fedorov popup has been added in the dev tier. Please let me know if you have more feedback. Thanks!

fedorov commented 3 years ago

Looks great, thanks!

fedorov commented 3 years ago

@mitianisb today when I clicked on Documentation, the page started to open inside the popup window. I was not able to reproduce it again. Do you have any idea what might have happened?

mitianisb commented 3 years ago

@fedorov Good Catch! Fixed and merged in dev tier. Thanks!