search

ImagingDataCommons / IDC-WebApp

Web Application front end for IDC (CORE REPO)
Apache License 2.0
6 stars 2 forks source link

Adjust behavior of TCGA Related Tab #545

Open G-White-ISB opened 3 years ago

G-White-ISB commented 3 years ago

Come up with user friendly/intuitive behavior for the Related/TCGA tab. Currently any selection of an attribute in the Related/TCGA tab will automatically selected the TCGA collection, if no TCGA collection is currently selected.

G-White-ISB commented 3 years ago

Tried simply disabling the auto selection of the TCGA collection when a related/TCGA attribute is selected. This was my idea but I admit trying it out its still not intuitive. The problem is that TCGA filters are only applied to TCGA collections, so one ends up with non cases with a TCGA filter selected and a non TCGA collection selected.

Two suggestions:

  1. We could probably change the label (0 cases) to (0 TCGA cases) in the TCGA tab.
  2. Disable the TCGA tab if TCGA collections are excluded by the TCGA filter.
Screen Shot 2021-02-09 at 1 22 28 PM
s-paquette commented 3 years ago

@madelyngreyes This is now in test so you can look at it, and I agree with the George the ultimate issue here is because TCGA filters only apply to TCGA collections, you wind up with a somewhat odd situation, especially down in the Collection list.

Eg. if you select a Disease Code of BRCA, you'll see TCGA-BRCA...and all of the other collections. Why? Because Disease Code only applies to the TCGA collections.

So, we either need to also select TCGA collections, or, we need to NOT apply TCGA filters only to TCGA. @fedorov @wlongabaugh @DavidPotCanuck

fedorov commented 3 years ago

I suggest we leave it as is in idc-test until the next confused soul complains about it.

G-White-ISB commented 3 years ago

@ulrikew wondering what you think about this.

ulrikew commented 3 years ago

It is somewhat confusing because when I select BRCA as disease code and limit the age at diagnosis all TCGA collections but the BRCA disappear from the list but other unrelated collections like QIN_headneck hang around. image

ulrikew commented 3 years ago

I don't have a good idea how to solve this right now and agree with Andrey, for now, to leave it as is. I will submit a new ticket with thoughts about addressing this issue as more collections become available.

fedorov commented 3 years ago

@dclunie do you want to add your thoughts to this issue?