search

ImagingDataCommons / IDC-WebApp

Web Application front end for IDC (CORE REPO)
Apache License 2.0
6 stars 2 forks source link

Need to be able to distinguish visually hyperlinks from text on the front page #556

Open fedorov opened 3 years ago

fedorov commented 3 years ago

Would it be possible to change the styling of the hyperlinks for the portal front page to indicate what text is hyperlinked? As is, it is impossible to know if certain text is hyperlinked or not, until you mouse over.

2021-02-24_12-29-01

It would be very helpful if hyperlinks were distinguished by underline, highlight, different color, bold, whatever.

fedorov commented 3 years ago

Interestingly, if I go to the "Account details" page, the styling of hyperlinks there is different.

image

G-White-ISB commented 3 years ago

Call out for opinions - should the hyperlinks be bold, underlined, etc?

fedorov commented 3 years ago

Making them underlined in all places would make the site consistent with itself.

pieper commented 3 years ago

Yes, a consistent underlining of links would be a web-standard approach.

s-paquette commented 3 years ago

The main issue is, due to the number of links on the site, it really makes the site look ungainly. Especially the Navbar.

Note that none of the other sites use underlining on their links: https://proteomic.datacommons.cancer.gov/pdc/ https://gdc.cancer.gov/access-data/data-access-processes-and-tools

There's a reason for this: it's visually ugly any time you have a large number of links, and in any kind of menu.

All of our links underline when hovered. We can bold them, or make them another color, but in general underlining makes for intense page clutter on page like ours. It's not required by 508 - all that's required is that they be visually distinct, and not rely on only color.

If nothing else, doing this will make our site look significantly different than the other Commons.

pieper commented 3 years ago

True, underlining isn't really the issue, just visually distinct and consistent on all our pages is the key issues. Good idea to try to maintain visual consistency with other data commons nodes.

fedorov commented 3 years ago

I have nothing to say other than restate the title of the issue: "Need to be able to distinguish visually hyperlinks from text on the front page"

fedorov commented 2 years ago

Curiously, PDC does not underscore the links, GDC portal does. cancer.gov and DataCommons pages do not underline the hyperlinks, so I guess this means we should just make the "Account" page appearance consistent with the front page.