ImagingDataCommons / IDC-WebApp

Web Application front end for IDC (CORE REPO)
Apache License 2.0
6 stars 2 forks source link

Improve usability of slider selector by allowing to specify the slider position #932

Open fedorov opened 2 years ago

fedorov commented 2 years ago

Currently, it is very very very difficult to precisely control slider position for small values (ie when range is 0 to 2000, it is very hard to set sliders to range 0-1, for example).

pgundluru commented 2 years ago

Currently the enhancement is applied to the below filters and while the slider function works the clear doesn't seem to clear the selection in the box.

Original filter (slice thickness) - Clear slider doesn't clear the selection in the box (the slider selected does clear)

Derived (quantitative analysis all filters) - Clear slider doesn't clear the selection in the box (the slider selected does clear)

Related (Age at diagnosis) - Clear slider doesn't clear the selection in the box (the slider selected does clear)

G-White-ISB commented 2 years ago

The new slider text boxes allow the user to input slider values, but the text box values would not necessarily sync with the slider range if the slider was updated by 'sliding' or pressing 'Clear slider'. I have a PR changing this behavior such that a change to the slider values will update the corresponding text boxes.

Also note: user must press enter in one text box after values are entered in order for the boxes to update the slider. I'm hoping that is intuitive

s-paquette commented 2 years ago

@pgundluru Now ready for testing

fedorov commented 2 years ago

The new slider text boxes allow the user to input slider values

I have to say, in my assessment, chances of anyone guessing that this functionality exists behind the gear icon are close to zero.

image
s-paquette commented 2 years ago

@fedorov We could make a new ticket to improve the UI of it, or keep this one open and move it into the next release, as you prefer.

fedorov commented 2 years ago

I'd just keep this one open, to simplify matters.

G-White-ISB commented 2 years ago

" chances of anyone guessing that this functionality exists behind the gear icon are close to zero" - Yes but that would be true for other functionality behind the gear icons, ie 'Sort by alpha, num'. Do you want to drop the gear icon in the slider panels and have all slider controls statically visible?

fedorov commented 2 years ago

Yes but that would be true for other functionality behind the gear icons

I do not agree with this. The key difference is that slider is visible without having to touch the gear icon. Other items you mentioned are not.

fedorov commented 2 years ago

But of course - all of this is subjective. It is not a priority to spend a lot of time on discussing or implementing this, all things considered.