search

IndiePass / indiepass-desktop

An IndieWeb Desktop app with extensions for sharing information to micropub endpoints and reading from microsub endpoints
https://indigenous.marksuth.dev
GNU General Public License v3.0
41 stars 1 forks source link

A11y concerns and semantics #149

Open binyamin opened 2 years ago

binyamin commented 2 years ago

I have a couple concerns about the HTML. I'm gonna take some liberty, and put in a PR with a rewrite of the markup. Of course, I'll make sure it runs correctly first.

Partial List of Concerns

  1. sidebar element doesn't exist. Probably meant to be aside.
  2. <a> should be <button>, since it doesn't actually open a new URL. ^button
  3. Right now, Every single heading element on the page is an <h3>. ^h1-6
    1. The heading-levels should be different, depending on the content. Like an outline.
    2. There should always be a top-level heading (h1).
  4. The title attribute is not ideal for screen-readers. ^title
Cambridgeport90 commented 2 years ago

I definitely support this one being visually impaired myself.

marksuth commented 2 years ago

This is awesome, thanks! I know how important accessibility is, and will be happy to implement your pull request, and I'll take a look through the code myself to see if I can spot any glaring issues as well.

Cheers, Mark