InseeFrLab / pynsee

pynsee package contains tools to easily search and download french data from INSEE and IGN APIs
https://pynsee.readthedocs.io/en/latest/
MIT License
69 stars 10 forks source link

Unify os.environ['https_proxy'] calls through whole package #122

Closed tgrandje closed 1 year ago

tgrandje commented 1 year ago

Sometimes https_proxy where constructed using os.environ['http_proxy'], sometimes using os.environ['https_proxy']. This PR unify the variable used (ie https_proxy)

hadrilec commented 1 year ago

@tgrandje, thanks a lot for all your contributions! I made some modifications on top of it to ensure consistency in the namespace. I would like to push on tgrandje-patch-https_proxy branch on tgrandje/pynsee to update this PR. Could you please give me this right? Otherwise, your commits and my follow-up commits are on this branch tgrandje-patch-https_proxy.

tgrandje commented 1 year ago

@hadrilec sure ! I might have done it, but I'm note 100% sure (doing this from my phone + not a specialist of github...). Can you check if this works ?

hadrilec commented 1 year ago

Thanks a lot, I have managed to push to your repo.

codecov-commenter commented 1 year ago

Codecov Report

Merging #122 (dcbe7b0) into master (32e52ce) will increase coverage by 0.08%. The diff coverage is 92.50%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   91.48%   91.56%   +0.08%     
==========================================
  Files         112      112              
  Lines        3640     3640              
==========================================
+ Hits         3330     3333       +3     
+ Misses        310      307       -3     
Impacted Files Coverage Δ
pynsee/download/_check_url.py 41.17% <0.00%> (ø)
pynsee/localdata/get_included_area.py 85.71% <ø> (ø)
pynsee/download/_load_data_from_schema.py 58.49% <50.00%> (ø)
pynsee/utils/_request_insee.py 86.90% <88.88%> (ø)
pynsee/geodata/_get_capabilities.py 100.00% <100.00%> (ø)
pynsee/geodata/_get_data_with_bbox.py 81.96% <100.00%> (ø)
pynsee/geodata/_get_geodata.py 92.30% <100.00%> (ø)
pynsee/localdata/__init__.py 100.00% <100.00%> (ø)
pynsee/localdata/get_area_list.py 100.00% <100.00%> (ø)
pynsee/sirene/_get_location_openstreetmap.py 80.00% <100.00%> (ø)
... and 16 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

tgrandje commented 1 year ago

@hadrilec Well, for someone who didn't have much time, you certainly had a busy weekend ! I'm not sure what to read of unsuccesfull tests, but let me know if there is anything I can do to help.