pynsee.localdata.get_geo_list doesn't keep "CHEFLIEU" columns if geo is not "region"

InseeFrLab / pynsee

pynsee package contains tools to easily search and download french data from INSEE and IGN APIs

https://pynsee.readthedocs.io/en/latest/

MIT License

67 stars 9 forks source link

pynsee.localdata.get_geo_list doesn't keep "CHEFLIEU" columns if geo is not "region" #136

Closed tgrandje closed 1 year ago

tgrandje commented 1 year ago

Hello Hadrien I see that get_geo_list returns a dataframe with "CHEFLIEU" as a column, but that is not the case if you ask for (say) a departement. I've tracked it down to line 172 and that seems intentional. Do you have objections to me setting a PR regarding that behaviour ? Thanks

hadrilec commented 1 year ago

@tgrandje ok fine, yes please make a PR I will review it whenever I have a bit of time, thanks a lot

tgrandje commented 1 year ago

https://github.com/InseeFrLab/pynsee/pull/137

tgrandje commented 1 year ago

Just done my PR (which will also includes the PR about the logger, sorry about that...).

hadrilec commented 1 year ago

solved by #142