InseeFrLab / pynsee

pynsee package contains tools to easily search and download french data from INSEE and IGN APIs
https://pynsee.readthedocs.io/en/latest/
MIT License
69 stars 10 forks source link

bug fix - get latest local data #157

Closed hadrilec closed 1 year ago

hadrilec commented 1 year ago

it should solve this issue #154

codecov-commenter commented 1 year ago

Codecov Report

Merging #157 (b430670) into master (a80238e) will decrease coverage by 26.94%. The diff coverage is 82.60%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           master     #157       +/-   ##
===========================================
- Coverage   92.38%   65.45%   -26.94%     
===========================================
  Files         117      117               
  Lines        3862     3824       -38     
===========================================
- Hits         3568     2503     -1065     
- Misses        294     1321     +1027     
Impacted Files Coverage Δ
pynsee/localdata/get_local_data.py 86.11% <50.00%> (-0.20%) :arrow_down:
pynsee/utils/_request_insee.py 60.27% <66.66%> (-23.29%) :arrow_down:
pynsee/localdata/_find_latest_local_dataset.py 93.02% <100.00%> (ø)
pynsee/localdata/_get_insee_local_onegeo.py 100.00% <100.00%> (ø)

... and 68 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

hadrilec commented 1 year ago

only test on get_last_release failed due to the failure of the rss flow, insee teams are working on it, code from this PR is fine