search

InseeFrLab / pynsee

pynsee package contains tools to easily search and download french data from INSEE and IGN APIs
https://pynsee.readthedocs.io/en/latest/
MIT License
67 stars 8 forks source link

Test against relevant python versions #172

Open tfardet opened 1 year ago

tfardet commented 1 year ago

I'd propose to stop testing against python 3.7, as it already reached end of life and start using 3.11 instead.

I also wonder whether it is necessary to test against all intermediate versions and whether oldest and newest alone would not be sufficient (especially given how long the tests take to run). No strong opinion, though, just wondering whether it's worth it.

hadrilec commented 1 year ago

Indeed, great idea, let's discontinue the testing on 3.7, and test only on 3.8 and 3.11 then. The tests module, should be adapted though because some tests are run only on 3.7

tfardet commented 1 year ago

OK, will try to look at that by the end of the week! (unless someone else does it first)

tgrandje commented 1 year ago

I'll handle this at the same time as the caching of tests.

hadrilec commented 9 months ago

I made this commit 860e27a3a058edf1c760171d3ae8f66275b78cdb in the PR #162, tests will be performed only on 3.8 and 3.11

hadrilec commented 8 months ago

after the merger of this PR #180, tests are made only on python 3.8 and 3.11

tfardet commented 8 months ago

Fixed by b6618715e1dc1dabe3e193ca2f1b8ce01d6682fe

tfardet commented 5 months ago

I thought we moved to test only against 3.8 and 3.11 but it seems it was reverted at some point later. Was there a specific reason for the reversion or should we move back to 3.8 and 3.11 only? Should we even move to 3.8 and 3.12 now that it's out?

More generally, should we define a policy for the python version we test? (I would propose to test against earliest version with security support and latest version only)