search

InseeFrLab / pynsee

pynsee package contains tools to easily search and download french data from INSEE and IGN APIs
https://pynsee.readthedocs.io/en/latest/
MIT License
69 stars 10 forks source link

bugfix - import object instead of module #173

Closed hadrilec closed 1 year ago

tfardet commented 1 year ago

Ah, yeah, I'm the one who introduced this bug... there is still two imports missing in test_pynsee_geodata/sirene.py. Sorry about that! Don't know why it did not appear in the tests, nor on my local machine... I did not expect the module to take precedence over the object when they have the same name, this really makes it a pain to manage imports...

EDIT: to be honest, given that strange bug (as far as I understand, this is not supposed to happen), I think the naming pattern in pynsee is detrimental and I would propose to rename GeoFrDataFrame.py to something else to avoid this kind of issue. More generally, this should probably progressively be done for the whole library whenever we have the occasion. I'll open an issue about that.

EDIT 2: see #174

tfardet commented 1 year ago

Wait, @hadrilec I just noticed that CI is checking master instead of the latest PR commit.

I don't know why we need checkout but if we use it, maybe this is what we need? https://github.com/actions/checkout#checkout-pull-request-head-commit-instead-of-merge-commit