search

InseeFrLab / pynsee

pynsee package contains tools to easily search and download french data from INSEE and IGN APIs
https://pynsee.readthedocs.io/en/latest/
MIT License
67 stars 8 forks source link

Test Python 3.8/3.11 + backup multiprocessing to get geodata #178

Closed tfardet closed 8 months ago

tfardet commented 9 months ago

Fixes #172 and #175

@hadrilec are these the main changes you had included in #162? If not, feel free to include whatever is missing.

tfardet commented 9 months ago

@hadrilec Well, it seems we now know where the 4h-long tests come from ^^"

tfardet commented 9 months ago

@hadrilec I won't have time to look at this for the moment, so if you can have a look, it would be worth checking what makes the multiprocessing fail. I also wonder whether this is the best way to handle this and if we shouldn't rather move to something like this, might be just as fast (faster?) and more reliable.

hadrilec commented 9 months ago

Thanks for the link, I will have a look. I agree async should be the way to go.

hadrilec commented 9 months ago

I did a mistake by pushing commits from the other PR, my bad, I will clean this up

tfardet commented 8 months ago

@hadrilec do you know when you'd have time to finish this part?

hadrilec commented 8 months ago

hi @tfardet, I plan to wrap this up before the 1st of January. In any case, a new release of the package must be created by next year because IGN and INSEE/SIREN APIs are changing.

tfardet commented 8 months ago

Great, let me know if you want me to force push or create another branch with my local version of fix-tests in case cleaning up turns up to be complicated

EDIT: actually, just in case, https://github.com/tfardet/pynsee/tree/fix-test-backup

hadrilec commented 8 months ago

nice, I will start from there