search

InseeFrLab / pynsee

pynsee package contains tools to easily search and download french data from INSEE and IGN APIs
https://pynsee.readthedocs.io/en/latest/
MIT License
70 stars 10 forks source link

tmp folder PR - bug #218

Open hadrilec opened 2 months ago

hadrilec commented 2 months ago

@tgrandje I merged the PR on tmp folder, but apparently tests are not successful. Would you mind to have a look? I can also remove the last commit if need be 94137fb

tgrandje commented 2 months ago

@hadrilec are you speaking of those tests?

If so, there is nothing useful in those logs but the (yet again) timeout. I'll ran those on my laptop to check if there's anything to do about it.

If my fears are confirmed (that is, that tests on github are now unreliable for unknown reasons), do you think we should test this on multiple python versions?

By the way, do you know if there might be a problem of shared ressources between pynsee and another project stored in InseeFrLab? I don't really know how github allocates ressources...

tgrandje commented 2 months ago

OK, the 3.10 tests ran like a charm, but only 32 tests where selected. I'll retry that after having removed the versions filters.

tgrandje commented 2 months ago

So I confirm everything worked fine on my laptop (84 tests passed in 43min). I vote to close this issue and get back on testing the impact of caching!

hadrilec commented 2 months ago

good that it works on your computer

tfardet commented 2 months ago

rereading the code, shouldn't it be a call to tempfile.TemporaryDirectory() here?

tgrandje commented 2 months ago

@tfardet in fact it's moved here

tfardet commented 2 months ago

ah right, I misread, sorry for the noise