ENH: Implemented composite filters for phase analysis

InsightSoftwareConsortium / ITKIsotropicWavelets

External Module for ITK, implementing Isotropic Wavelets and Riesz Filter for multiscale phase analysis.

Apache License 2.0

13 stars 11 forks source link

ENH: Implemented composite filters for phase analysis #128

Closed cramraj8 closed 4 years ago

cramraj8 commented 5 years ago

Implemented 2 composite filters for

wavelet coefficients extraction of different highpassband-level pairs
reconstruction of phase analysis results

This PR includes header files, C-Test files, and example scripts.

Filter 1: WaveletCoeffsInverseFFT filter does

preprocessing like FFT padding and zero DCing
FFT transform and wavelet forward analysis and finally return all the wavelet coefficient components as outputs in its spatial domain.

Filter 2: WaveletCoeffsPhaseAnalysis filter does

preprocessing like FFT padding and zero DCing
FFT transform and wavelet forward analysis
Monogenic signal generation and phase analysis
image reconstruction using inverse wavelet analysis and finally return the reconstructed image in the spatial domain.

phcerdan commented 5 years ago

Looking good @cramraj8, thanks! Could you handle the following points:

[ ] Provide documentation for the new classes in their headers. See other ITK classes for examples.
[x] Provide a complete git message that describes the features added (not the technicalities) on this PR. And also any detail that you think is worth mention in the implementation (if any). Also the tittle is too long, as you can see in the github interface.

thewtex commented 5 years ago

As the CI tests note, style updates can be made to address the style test:

https://open.cdash.org/testDetails.php?test=787488111&build=6027749

thewtex commented 5 years ago

Also todo: Add the ENH: prefix and more content to the commit message, as suggested by @phcerdan .

hjmjohnson commented 5 years ago

@cramraj8 This is almost ready to merge. Will you please address the last few concerns by @phcerdan

phcerdan commented 4 years ago

@cramraj8, this filters are going to ease up the usage of the module, which is great, and it is almost ready to merge, will you have time to finish it?