InsightSoftwareConsortium / ITKIsotropicWavelets

External Module for ITK, implementing Isotropic Wavelets and Riesz Filter for multiscale phase analysis.
Apache License 2.0
13 stars 11 forks source link

Python Wrapping errors with ITK v5.1.1 #134

Closed mseng10 closed 3 years ago

mseng10 commented 4 years ago

We are unable to run Python Wrapping for ITKIsotropicWavelets without wrapping errors. The terminal output is provided below when ran in the following conditions:

Screen Shot 2020-08-26 at 11 11 23 AM

These errors are consistent amongst MacOS and Windows builds as well. I have provided a link to all 3 failing builds here. This issue will require the following changes:

phcerdan commented 4 years ago

Thanks for the report and guide. It seems that ${ITKM_VIC${t}${d}} here is undefined.

phcerdan commented 4 years ago

I don't have problems wrapping it locally with latest ITK master 26079ef39 and latest IsotropicWavelets 8f28a166.

Are you using a non-default option for WRAP TYPES? here are mine, I would say they are the default ones.

ITK_WRAP_CASTXML:BOOL=ON
ITK_WRAP_DOC:BOOL=OFF
ITK_WRAP_EXPLICIT:BOOL=OFF
ITK_WRAP_IMAGE_DIMS:STRING=2;3
ITK_WRAP_JAVA:BOOL=OFF
ITK_WRAP_PERL:BOOL=OFF
ITK_WRAP_PYTHON:BOOL=ON
ITK_WRAP_PYTHON_LEGACY:BOOL=ON
ITK_WRAP_RUBY:BOOL=OFF
ITK_WRAP_SWIGINTERFACE:BOOL=ON
ITK_WRAP_TCL:BOOL=OFF
ITK_WRAP_VECTOR_COMPONENTS:STRING=2;3;4
ITK_WRAP_complex_double:BOOL=OFF
ITK_WRAP_complex_float:BOOL=ON
ITK_WRAP_covariant_vector_double:BOOL=OFF
ITK_WRAP_covariant_vector_float:BOOL=ON
ITK_WRAP_double:BOOL=OFF
ITK_WRAP_float:BOOL=ON
ITK_WRAP_rgb_unsigned_char:BOOL=ON
ITK_WRAP_rgb_unsigned_short:BOOL=OFF
ITK_WRAP_rgba_unsigned_char:BOOL=ON
ITK_WRAP_rgba_unsigned_short:BOOL=OFF
ITK_WRAP_signed_char:BOOL=OFF
ITK_WRAP_signed_long:BOOL=OFF
ITK_WRAP_signed_long_long:BOOL=OFF
ITK_WRAP_signed_short:BOOL=ON
ITK_WRAP_unsigned_char:BOOL=ON
ITK_WRAP_unsigned_long:BOOL=OFF
ITK_WRAP_unsigned_long_long:BOOL=OFF
ITK_WRAP_unsigned_short:BOOL=OFF
ITK_WRAP_vector_double:BOOL=OFF
ITK_WRAP_vector_float:BOOL=ON
dzenanz commented 3 years ago
  • [ ] Create an API token on PyPI for the package, and put in the repository Settings -> Secrets under the key pypi_password.

I think that only @phcerdan can do this, as he is the only one listed as maintainer.

I hastily created tag v0.6.0, thinking that everything is working already :(

phcerdan commented 3 years ago

image

The robot is a maintainer, if you have password for that user you can do it. If not, let me know the user I have to invite to the list of maintainers.

phcerdan commented 3 years ago

Closing, I think this is outdated, the CI seems green for modern PRs. Please feel free to re-open if needed.

dzenanz commented 3 years ago

Ideally, add me and Matt.