COMP: Fix warnings unused type and unreachable value

InsightSoftwareConsortium / ITKIsotropicWavelets

External Module for ITK, implementing Isotropic Wavelets and Riesz Filter for multiscale phase analysis.

Apache License 2.0

13 stars 11 forks source link

COMP: Fix warnings unused type and unreachable value #155

Closed phcerdan closed 2 years ago

phcerdan commented 2 years ago

-Wtype-limits <0 always false -Wunused-local-typedefs ValueType

phcerdan commented 2 years ago

I am not sure what's going on with the segfaults. Is there a way to check that the download of data works in the server? For work I mean that the .tiff image for tests are actually images and not http response web pages.

I cannot think in anything else triggering those segfaults. Locally, the download of data works ok...

dzenanz commented 2 years ago

Previously, similar problems were either due to undefined behavior manifesting differently in CI, or just unexplained difference between CI and local compiler/whatever.

The way to debug this, is to look at https://github.com/InsightSoftwareConsortium/ITKIsotropicWavelets/blob/master/.github/workflows/build-test-package.yml and make your local environment/setup as similar to that as you can. Many times it was due to some setting difference between local system and CI.