search

InsightSoftwareConsortium / ITKIsotropicWavelets

External Module for ITK, implementing Isotropic Wavelets and Riesz Filter for multiscale phase analysis.
Apache License 2.0
13 stars 11 forks source link

Wavelet filter generators are not setting the wavelet instance #18

Closed jhlegarreta closed 7 years ago

jhlegarreta commented 7 years ago

The itk::WaveletFrequencyForward or the itk::WaveletFrequencyFilterBankGenerator classes do not seem to have a SetWavelet or SetIsotropicWavelet method so that the specific wavelet object instance created (and hence, its properties) is used.

phcerdan commented 7 years ago

Yeah, not sure if the users really want to instantiate the Wavelet for themselves, and then Set it, as you suggest. Or let the generator do it with just the type of the wavelet as a template parameter, which is the current behavior.

For testing purposes, we can create proper unit tests in #17, and then we don't really have to worry about this. But not sure though, happy to hear any elaborated opinion on why this is preferred.

jhlegarreta commented 7 years ago

I think it's a good point to use wavelets through the generator. However, has the generator any method to set the wavelet's properties? What if wavelets have different properties?

IMHO, if a class has some properties that are exposed through a Set method, I'd like to be able to use an specific instance of it, whether through the generator or not. Is this is possible right now?