search

InsightSoftwareConsortium / ITKIsotropicWavelets

External Module for ITK, implementing Isotropic Wavelets and Riesz Filter for multiscale phase analysis.
Apache License 2.0
13 stars 11 forks source link

Wrap for python std::vector<ImagePointer> in helper functions. #67

Open phcerdan opened 6 years ago

phcerdan commented 6 years ago

Asked in the discourse forum: https://discourse.itk.org/t/how-to-wrap-a-std-vector-imagepointer-in-swig-with-itkwrap/227

phcerdan commented 5 years ago

WIP in branch: https://github.com/InsightSoftwareConsortium/ITKIsotropicWavelets/tree/use_vector_container

This wip was using itkVectorContainer instead of std::vector. I think it would be better the std::vector option.

phcerdan commented 5 years ago

@fbudin69500 merged in ITK an std::vector wrapping: https://github.com/InsightSoftwareConsortium/ITK/commit/bd8169b433679930c8acfe0e24c8b5a5c663a833

We just need to figure out how to re-use the wrapping in an external module.

dzenanz commented 3 years ago

Can this issue be closed now?

phcerdan commented 3 years ago

I don't think anything has changed to close it. Are open issues a burden? We can add a enhancement label to it, to differentiate them from bugs.

dzenanz commented 3 years ago

CI with Python packages built successfully, that's why I thought we could close a couple of these bugs.