search

InsightSoftwareConsortium / ITKIsotropicWavelets

External Module for ITK, implementing Isotropic Wavelets and Riesz Filter for multiscale phase analysis.
Apache License 2.0
13 stars 11 forks source link

4 tests are failing. #70

Closed hjmjohnson closed 6 years ago

hjmjohnson commented 6 years ago

The following tests FAILED: 22 - itkWaveletFrequencyInverseTest2D (Failed) 23 - itkWaveletFrequencyInverseTest2DMultiLevelMultiBand (Failed) 47 - itkFrequencyExpandAndShrinkTest2D (Failed) 48 - itkFrequencyExpandAndShrinkTest3D (Failed) Errors while running CTest

phcerdan commented 6 years ago

thanks @hjmjohnson , will have a look. Do you have a cdash link with details?

hjmjohnson commented 6 years ago

No, but what I saw was image physical space and as not the same.

Seems like new reference data are needed now that ITK supports this info in more file formats.

Sent from my iPhone

On Feb 1, 2018, at 2:54 PM, PHCerdan notifications@github.com wrote:

thanks @hjmjohnson , will have a look. Do you have a cdash link with details?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

phcerdan commented 6 years ago

Solved. I have added a ChangeInformationFilter in the test to recover the input image metadata after the inverseWavelet.

Also, there was a bug with the ExpandViaFFT, not setting the output spacing.

hjmjohnson commented 6 years ago

Awesome! PS: I'm working on the bug you reported regarding GPU concept checking.

phcerdan commented 6 years ago

Nice, thanks!