search

Instamojo / instamojo-android-sdk

Android SDK for Instamojo Payments
17 stars 20 forks source link

Add support for Rupay detection and logo display #25

Open saich opened 7 years ago

vipulasri commented 5 years ago

@saich This works properly. Rupay card is detected on the 5 digit.

saich commented 5 years ago

@vipulasri Can you share a screenshot?

https://github.com/Instamojo/instamojo-android-sdk/blob/master/android-sdk/src/main/res/drawable-xhdpi/ic_accepted_cards.png doesn't include Rupay, so I'm not sure where the Rupay icon is being displayed from.

vipulasri commented 5 years ago

@saich I am talking about detection, as the title of the issue suggests. On detection its working on 5 digit and yeah you are right its not present in the accepted cards image. But don't you think adding all the accepted cards in EditText's right/end drawable will lead to less editable area.