search

Instant-Visio / InstantVisio-WebApp

MIT License
10 stars 2 forks source link

Node version (nvm) #174

Open MattiaPrimavera opened 4 years ago

MattiaPrimavera commented 4 years ago

Is there a particular reason to use two different node versions for firebase functions and the front app ?

Abibibi commented 4 years ago

Node 8 is needed for Firebase functions

MattiaPrimavera commented 4 years ago

Yep but from functions docs:

You'll need a Node.js environment to write functions, and you'll need the Firebase CLI to deploy functions to the Cloud Functions runtime. Node.js versions 8 and 10 are supported. For installing Node.js and npm, Node Version Manager is recommended.

HugoGresse commented 4 years ago

Node 10 on GCP is in "beta" but we could indeed switch to 10 on both without issue.

MattiaPrimavera commented 4 years ago

Which part of our service is using GCP ? Well if it's beta, better not to change that for production ... but the docs I linked seem saying it's supported for firebase functions, not beta :)

HugoGresse commented 4 years ago

Firebase run on GCP. so Functions are Google Cloud Functions under the shell. You can probably make another pr to change the node version on functions and remove the .nvmrc.