A friendly request: Thanks for visiting control-flag GitHub repository! If you find control-flag useful, we would appreciate a note from you (to niranjan.hasabnis@intel.com). And, of course, we love testimonials!
-- The ControlFlag Team
ControlFlag is a self-supervised idiosyncratic pattern detection system that learns typical patterns that occur in the control structures of high-level programming languages, such as C/C++, by mining these patterns from open-source repositories (on GitHub and other version control systems). It then applies learned patterns to detect anomalous patterns in user's code.
ControlFlag's pattern anomaly detection system can be used for various problems such as typographical error detection, flagging a missing NULL check to name a few. This PoC demonstrates ControlFlag's application in the typographical error detection.
Figure below shows ControlFlag's two main phases: (1) pattern mining phase, and (2) scanning for anomalous patterns phase. The pattern mining phase is a "training phase" that mines typical patterns in the user-provided GitHub repositories and then builds a decision-tree from the mined patterns. The scanning phase, on the other hand, applies the mined patterns to flag anomalous expressions in the user-specified target repositories.
More details can be found in our MAPS paper (https://arxiv.org/abs/2011.03616).
src
: Source code for ControlFlag for typographical error detection systemscripts
: Scripts for pattern mining and scanning for anomaliesquick_start
: Scripts to run quick start testsgithub
: Scripts and data for downloading GitHub repos.tests
: unit testsControlFlag can be built on Linux and MacOS.
Tested build configuration on Linux-based systems
Tested build configuration on MacOS
$ cd control-flag
$ cmake .
$ make -j
$ make test
All tests in make test
should pass.
Download the training data for the language of interest depending on the memory constraints of your device. Note, however, that using smaller datasets may lead to reduced accuracy in the results ControlFlag produces and possibly an increase in the number of false positives it generates.
Language | Dataset name | Size on disk | Memory requirements | Direct link | MD5 checksum |
---|---|---|---|---|---|
C | Small | ~100MB | ~400MB | link | 2825f209aba0430993f7a21e74d99889 |
C | Medium | ~450MB | ~1.3GB | link | aab2427edebe9ed4acab75c3c6227f24 |
C | Large | ~9GB | ~13GB | link | 1ba954d9716765d44917445d3abf8e85 |
C++ | Small | ~200MB | ~500MB | link | f954486e20961f0838ac08e5d4dbf312 |
C++ | Medium | ~500MB | ~1.3GB | link | a5c18ea1cdbe354b93aabf9ecaa5b07a |
C++ | Large | ~1.2GB | ~3GB | link | 4f5ffc1ab942eaba399cafd5be8bb45f |
PHP | Small | ~120MB | ~1GB | link | 5a1cc4c24a20de7dad1b9f40661d517a |
$ Download <tgz_file> from the link above.
$ (optional) md5sum <tgz_file>
$ tar -zxf <tgz_file>
To scan C code of your choice, use below command:
$ scripts/scan_for_anomalies.sh -d <directory_to_be_scanned_for_anomalies> -t <training_data>.ts -o <output_directory_to_store_log_files> -l 1
To scan C++ code of your choice, use below command:
$ scripts/scan_for_anomalies.sh -d <directory_to_be_scanned_for_anomalies> -t <training_data>.ts -o <output_directory_to_store_log_files> -l 4
Once the run is complete (which could take some time depending on your system and the number of programs from your repository that can be scanned by ControlFlag,) refer to the section below to understand scan output.
In this test for C language programs, we will mine patterns from Glb-director project of GitHub and apply them to flag anomalies in GitHub's brubeck project.
Simply run below command:
cd quick_start && ./test1_c.sh
If everything goes well, you can see output from the scanner in test1_scan_output
directory. Look for "Potential anomaly" label in it by grep "Potential anomaly" -C 5 \*.log
, and you should see output like below:
thread_6.log-Level:TWO Expression:(parenthesized_expression (binary_expression ("==") (identifier) (non_terminal_expression))) found in training dataset:
Source file: brubeck/src/server.c:266:5:(s == sizeof(fdsi))
thread_6.log-Autocorrect search took 0.000 secs
thread_6.log:Potential anomaly
thread_6.log-Did you mean:(parenthesized_expression (binary_expression ("==") (identifier) (non_terminal_expression))) with editing cost:0 and occurrences: 1
thread_6.log-Did you mean:(parenthesized_expression (binary_expression ("==") (identifier) (null))) with editing cost:1 and occurrences: 25
thread_6.log-Did you mean:(parenthesized_expression (binary_expression ("==") (identifier) (identifier))) with editing cost:1 and occurrences: 5
thread_6.log-Did you mean:(parenthesized_expression (binary_expression (">=") (identifier) (non_terminal_expression))) with editing cost:1 and occurrences: 3
thread_6.log-Did you mean:(parenthesized_expression (binary_expression ("==") (non_terminal_expression) (non_terminal_expression))) with editing cost:1 and occurrences: 2
The anomaly is flagged for brubeck/src/server.c
at line number 266
.
If you do not want to generate training data yourself, go to Evaluation step below.
In this phase, we mine the idiosyncratic patterns that appear in the control
structures of high-level language such as C. This PoC mines patterns from if
statements that appear in C programs.
If you want to use your own repository for mining patterns, jump to Step 1.2.
1.1 Downloading GitHub repos for C language having more than 100 stars
Steps below show how to download GitHub repos for C language that have more than 100 stars
(c100.txt
) and generate training data. training_repo_dir
is a directory
where the command below will clone all the repos.
$ cd github
$ python download_repos.py -f c100.txt -o <training_repo_dir> -m clone -p 5
1.2 Mining patterns from downloaded repositories
You can use your own repository to mine for expressions by passing it in
place of
mine_patterns.sh
script helps for this. It's usage is as below:
Usage: ./mine_patterns.sh -d <directory_to_mine_patterns_from> -o <output_file_to_store_training_data>
Optional:
[-n number_of_processes_to_use_for_mining] (default: num_cpus_on_system)
[-l source_language_number] (default: 1 (C), supported: 1 (C), 2 (Verilog), 3 (PHP), 4 (C++)
[-g github_repo_id] (default: 0) A unique identifier for GitHub repository, if any
We use it as:
$ scripts/mine_patterns.sh -d <training_repo_dir> -o <training_data_file> -l 1
<training_dat_file>
contains conditional expressions in C language that are
found in the specified GitHub repos and their AST (abstract syntax tree) representations.
You can view this file as a text file, if
you want.
We can run scan_for_anomalies.sh
script to scan target directory of interest.
Its usage is as below.
Usage: ./scan_for_anomalies.sh -t <training_data> -d <directory_to_scan_for_anomalous_patterns>
Optional:
[-c max_cost_for_autocorrect] (default: 2)
[-n max_number_of_results_for_autocorrect] (default: 5)
[-j number_of_scanning_threads] (default: num_cpus_on_systems)
[-o output_log_dir] (default: /tmp)
[-l source_language_number] (default: 1 (C), supported: 1 (C), 2 (Verilog), 3 (PHP), 4 (C++))
[-a anomaly_threshold] (default: 3.0)
As a part of scanning for anomalies, ControlFlag also suggests possible
corrections in case a conditional expression is flagged as an anomaly. 25
is the
max_cost
for the correction -- how close should the suggested correction be to
possibly mistyped expression. Increasing max_cost
leads to suggesting more
corrections. _If you feel that the number of reported anomalies is
high, consider reducing anomaly_threshold
to 1.0
or less_.
Under output_log_dir
you will find multiple log files corresponding to
the scan output from different scanner threads. Potential anomalies are reported
with "Potential anomaly" as a label. Command below will report log files
containing at least one anomaly.
$ grep "Potential anomaly" <output_log_dir>/thread_*.log
A sample anomaly report looks like below:
Level:<ONE or TWO> Expression: <AST_for_anomalous_expression>
Source file and line number: <Source code expression with line number having the anomaly>
Potential anomaly
Did you mean ...
The text after "Did you mean" shows possible corrections to the anomalous expression.
In the spirit of community service, we routinely scan open-source packages using ControlFlag. We have found several programming errors in various open-source projects. We are mentioning some of the errors that are confirmed by the respective developers below.
Issue link | Language | Erroneous expression | Comment |
---|---|---|---|
https://github.com/curl/curl/pull/6193 | C | if (s->keepon > TRUE) |
Comparison between a variable and a boolean using > |
https://github.com/vrpn/vrpn/issues/263 | C | (l_inbuf[2] \| 1) , if (l_inbuf[3] \| 1) |
Incorrect use of \| instead of & |
https://github.com/vlm/asn1c/issues/443 | C | if(!saved_aid && 0) |
Dead code |
https://github.com/shoes/shoes3/issues/468 | C | if ((attr == 39) \|\| (attr = 49)) |
Incorrect use of = instead of == |
https://github.com/IoLanguage/io/issues/455 | C | if (UArray_greaterThan_(self, other) \| UArray_equals_(self, other)) |
Inefficient use of \| instead of \|\| |
https://github.com/IoLanguage/io/issues/455 | C | if( ln = (SFG_Node *)node->Next ) , if( ln = (SFG_Node *)node->Prev ) |
Missing parenthesis |
https://github.com/elua/elua/issues/170 | C | if (Protection_Level_1_Register &= FMI_Sector_Mask) |
Missing parenthesis |