IntellectualSites / FastAsyncWorldEdit

Blazingly fast world manipulation for artists, builders and everyone else: https://www.spigotmc.org/resources/13932/
Other
609 stars 215 forks source link

Replacing enderchests generates errors/half chests #1092

Closed markaabo closed 3 years ago

markaabo commented 3 years ago

Server Implementation

Paper

Server Version

1.16.5

Describe the bug

The bugs: When trying to //replace enderchests to trapped chests it either generates an error, or it makes half block trapped chests depending on which way you do it.

Doing //replace ender_chest ^trapped_chest results in this: 2021-05-22_12 58 12

Doing //replace trapped_chest[type=single] ^ender_chest results in an error: ReplaceError.txt

Server plugins: BKCommonLib-1.16.5-v2, F3NPerm-2.5, FastAsyncWorldEdit-Bukkit-1.16-688, HolographicDisplays, LightCleaner-1.16.5-v1, LuckPerms-Bukkit-5.3.42, PlaceholderAPI-2.10.9, RollbackCore-3.5.0-BETA (for 1.13.2 or newer), simplereserve-1.0.1, SurvivalGames, TitleManager-2.3.3, worldguard-bukkit-7.0.4

To Reproduce

Place ender_chest and/or trapped_chest Select the area of the placed chests Do //replace ender_chest ^trapped_chest to reproduce the half chest bug Do //replace trapped_chest[type=single] ^ender_chest to reproduce the error

Expected behaviour

When doing //replace ender_chest ^trapped_chest it should just replace any ender_chest with trapped_chest and keep original orientation.

When doing //replace trapped_chest[type=single] ^ender_chest it should replace any single trapped_chest with ender_chest and keep original orientation.

Screenshots / Videos

No response

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/b6a5fe23f1b84476b9c9900a9b2aec6c

Fawe Version

FastAsyncWorldEdit-Bukkit-1.16-688

Checklist

Anything else?

The 2 bugs was firstly posted by me in another issue report, but it got closed before finding the new issues, hense the new issue post. https://github.com/IntellectualSites/FastAsyncWorldEdit/issues/1081

MattBDev commented 3 years ago

This is an interesting issue because I thought that we previously resolved this.

dordsor21 commented 3 years ago

Ender chests do not have the "type" tag in their blockstate and thus the ^ flag cannot be used. You will instead need to use individual [facing=DIRECTION] states for replacing, much like you would assume to need to be used for replacing chests with stairs, for example. This is therefore technically a feature request to allow the blockstates that can be kept, to be kept and discarding others.