IntellectualSites / FastAsyncWorldEdit

Blazingly fast world manipulation for artists, builders and everyone else: https://www.spigotmc.org/resources/13932/
Other
578 stars 207 forks source link

Instantiation of convex polyhedral region seems to not work sometimes #2805

Open cheeezburga opened 4 days ago

cheeezburga commented 4 days ago

Server Implementation

Paper

Server Version

1.20.5/6

Describe the bug

I'm not sure what's causing said bug, but as stated in the title, sometimes when instantiating a convex polyhedral region, and then using said region in an EditSession or something (I used EditSession#setBlocks), the blocks aren't properly modified. This is because the region, while it has all its vertices, doesnt have all the blocks that it should have - see this (me discussing the issue on Discord) for more info.

To Reproduce

  1. Try to instantiate 2 convex polyhedral regions back to back.

Expected behaviour

It should populate the region with all the blocks, instead of just the vertices.

Screenshots / Videos

image

I know this doesn't show much, nor is it easy to see really, but this is the same screenshot I put in the Discord when discussing it. Check the link above that goes to the Discord for more context here.

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/58227cfeef4043b6a7d26f1dd759d9b2

Fawe Version

FastAsyncWorldEdit version 2.10.1-SNAPSHOT-778;c77d341

Checklist

Anything else?

No response

dordsor21 commented 4 days ago

Try on the latest version, There have been some changes related to region block setting

cheeezburga commented 3 days ago

Seems to still be an issue with the latest snapshot

dordsor21 commented 3 days ago

Is it definitely with exactly the same order of setting the points, etc. (between WE and FAWE)? There are no differences in the region classes

cheeezburga commented 3 days ago

I'm using a different set of points with each test that I do, but yeah the region still (seemingly at random) sometimes doesn't initialize properly. Like when I set the blocks of said created region, sometimes it fills them all properly, and other times it fills only the vertices, and other times it fills (again seemingly) random blocks. I haven't been able to recreate this on WE but I'll give it another go later