search

InterACTWEL / interactactwel-django-app

0 stars 4 forks source link

Fix issue with npm install and legacy deps #97

Closed machristie closed 2 years ago

machristie commented 2 years ago

Also removed node-sass and switch to more modern dart-sass

machristie commented 2 years ago

@codexpotech Can you review this PR?

machristie commented 2 years ago

@dinukadesilva Can you review this PR?

dinukadesilva commented 2 years ago

@machristie I tested the full cycle. Everything works fine except the yarn serve throws an error whenever the development server (yarn serve inside interactwel) restarted whenever a code changes. But, if I manually start the server again, it works. A little wired. 

40% building 1/4 modules 3 active ...dex=0&id=aae30ed8&scoped=true&lang=css&Browserslist: caniuse-lite is outdated. Please run next command `yarn upgrade caniuse-lite browserslist`                                               91% additional chunk assets processing HotModuleReplacementPlugin/Users/dinukadesilva/Documents/iub-circ/repo/interactactwel-django-app/interactwel/node_modules/webpack/lib/HotModuleReplacementPlugin.js:287
                                                                        } = compilation.getPathWithInfo(hotUpdateChunkFilename, {
                                                                                        ^

TypeError: compilation.getPathWithInfo is not a function
    at /Users/dinukadesilva/Documents/iub-circ/repo/interactactwel-django-app/interactwel/node_modules/webpack/lib/HotModuleReplacementPlugin.js:287:26
    at SyncHook.eval [as call] (eval at create (/Users/dinukadesilva/Documents/iub-circ/repo/interactactwel-django-app/interactwel/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:16:1)
    at SyncHook.lazyCompileHook (/Users/dinukadesilva/Documents/iub-circ/repo/interactactwel-django-app/interactwel/node_modules/tapable/lib/Hook.js:154:20)
    at /Users/dinukadesilva/Documents/iub-circ/repo/interactactwel-django-app/interactwel/node_modules/@vue/cli-service/node_modules/webpack/lib/Compilation.js:1299:37
    at AsyncSeriesHook.eval [as callAsync] (eval at create (/Users/dinukadesilva/Documents/iub-circ/repo/interactactwel-django-app/interactwel/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)
    at AsyncSeriesHook.lazyCompileHook (/Users/dinukadesilva/Documents/iub-circ/repo/interactactwel-django-app/interactwel/node_modules/tapable/lib/Hook.js:154:20)
    at Compilation.seal (/Users/dinukadesilva/Documents/iub-circ/repo/interactactwel-django-app/interactwel/node_modules/@vue/cli-service/node_modules/webpack/lib/Compilation.js:1242:27)
    at /Users/dinukadesilva/Documents/iub-circ/repo/interactactwel-django-app/interactwel/node_modules/@vue/cli-service/node_modules/webpack/lib/Compiler.js:550:17
    at _done (eval at create (/Users/dinukadesilva/Documents/iub-circ/repo/interactactwel-django-app/interactwel/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)
    at eval (eval at create (/Users/dinukadesilva/Documents/iub-circ/repo/interactactwel-django-app/interactwel/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:32:22)
    at /Users/dinukadesilva/Documents/iub-circ/repo/interactactwel-django-app/interactwel/node_modules/@vue/cli-service/node_modules/webpack/lib/Compilation.js:1093:12
    at /Users/dinukadesilva/Documents/iub-circ/repo/interactactwel-django-app/interactwel/node_modules/@vue/cli-service/node_modules/webpack/lib/Compilation.js:1005:9
    at processTicksAndRejections (internal/process/task_queues.js:77:11)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
machristie commented 2 years ago

@dinukadesilva thanks for testing. What version of node are you using?

machristie commented 2 years ago

Hi @dinukadesilva, I've fixed the issue you reported. I downgraded to a slightly older version of webpack which doesn't have that issue.

Can you retest please?

dinukadesilva commented 2 years ago

It works now @machristie Thank you

machristie commented 2 years ago

Thanks @dinukadesilva. Can you also merge it? I don't rights to merge.