When I tried cloning this GitHub repo, I straight way got the following issue:
Cloning into 'cardano-addresses'...
remote: Enumerating objects: 22520, done.
remote: Counting objects: 100% (1189/1189), done.
remote: Compressing objects: 100% (135/135), done.
remote: Total 22520 (delta 1113), reused 1081 (delta 1054), pack-reused 21331 (from 1)
Receiving objects: 100% (22520/22520), 79.32 MiB | 13.77 MiB/s, done.
Resolving deltas: 100% (17622/17622), done.
fatal: cannot create directory at 'core/test/golden/addresses_excess_behave_track_soul_table_wear_ocean_cash_stay_nature_item_turtle_palm_soccer_lunch_horror_start_stumble_month_panic_right_must_lock_dress': File name too long
ext4 has a path limit of 255 bytes and that relative path has already 171 characters, so it is very easy to exceed the limit when trying to clone the project into an already moderately long subdir. This gets worse on top of other filesystems like ecryptfs
Solution
In order to improve portability, this PR renames the golden files to only contain the first 8 characters of the base16 encoding of the result of hashing the mnemonic key using sha3_256 instead of inlining the actual mnemonic key. It also adds a missing _ (underscore) in the name of inspects* files for consistency with the addresses_* files.
Motivation
When I tried cloning this GitHub repo, I straight way got the following issue:
ext4has a path limit of 255 bytes and that relative path has already 171 characters, so it is very easy to exceed the limit when trying to clone the project into an already moderately long subdir. This gets worse on top of other filesystems likeecryptfsSolution
In order to improve portability, this PR renames the golden files to only contain the first 8 characters of the base16 encoding of the result of hashing the mnemonic key using
sha3_256instead of inlining the actual mnemonic key. It also adds a missing_(underscore) in the name ofinspects*files for consistency with theaddresses_*files.