IntersectMBO / ouroboros-consensus

Implementation of a Consensus Layer for the Ouroboros family of protocols
https://ouroboros-consensus.cardano.intersectmbo.org
Apache License 2.0
35 stars 23 forks source link

Mempool benchmark is flaky #313

Open nfrisby opened 1 year ago

nfrisby commented 1 year ago

The CI on three PRs that do not change any code (309, 311, 312) failed due to the mempool benchmark.

amesgen commented 1 year ago

I have seen occasional (definitely flaky) failures of the mempool benchmark since their inception (might be related to higher GitHub Actions infra load?). We should definitely fix this to both remove the scary red marks and make the benchmarks more indicative, such that they could even be marked as "Required" eventually (they are not currently).

Potential approaches:

jorisdral commented 1 year ago

Another potential improvement, which could serve as an intermediate solution: