search

Ionaru / easy-markdown-editor

EasyMDE: A simple, beautiful, and embeddable JavaScript Markdown editor. Delightful editing for beginners and experts alike. Features built-in autosaving and spell checking.
https://stackblitz.com/edit/easymde
MIT License
2.39k stars 316 forks source link

Hyperlink text getting doubled each time click on link #25

Closed Gajendran7 closed 2 years ago

Gajendran7 commented 6 years ago

I'm submitting a...

Reproduction steps

  1. Navigate to editor and enter some link
  2. Select the link and click on link icon in header (multiple times)

Version information

Browser type and version: Chrome (Desktop) - Latest version EasyMDE version: NA 2018-09-03_19-37-42

Ionaru commented 6 years ago

The demo site uses the older SimpleMDE editor. Can you reproduce this with a more recent version?

(Still need to build a new demo website, sorry!)

Jetski5822 commented 5 years ago

Yeah - it repros locally too using the latest editor here :(

Ionaru commented 5 years ago

Alright I've tracked down the issue, but what do you expect to happen when you click on the link button in this situation?

Should the link be removed or should nothing happen?

n-3-0 commented 5 years ago

I would think that, since the link button is highlighted, it should behave consistently with other buttons and act as a toggle, removing the link.

danielok1993 commented 5 years ago

I have added toggling for links and images. I will submit pull request soon 👍

nerg4l commented 3 years ago

@danielok1993 Are you still planning to make a PR?

danielok1993 commented 3 years ago

@nerg4l this was long ago, but I did make a PR. You can view it in the Pull Request section and copy what I have implemented, as my PR was not merged.

nerg4l commented 3 years ago

Thanks for the info @danielok1993, I found it #95