search

Ionaru / easy-markdown-editor

EasyMDE: A simple, beautiful, and embeddable JavaScript Markdown editor. Delightful editing for beginners and experts alike. Features built-in autosaving and spell checking.
https://stackblitz.com/edit/easymde
MIT License
2.39k stars 316 forks source link

CodeMirror CSS should be scoped to EasyMDE #252

Closed infime closed 3 years ago

infime commented 3 years ago

Describe the bug

Some CSS selectors (specifically .CodeMirror) are too broad and affect other instances of CodeMirror in an application.

To Reproduce

Import EasyMDE CSS into an app that is already using CodeMirror. Other instances of CodeMirror will have styles intended specifically for EasyMDE applied.

Expected behavior

EasyMDE CSS to only affect it's instance(s) of CodeMirror.

I'd be happy to get this going in a PR.

Ionaru commented 3 years ago

I've added extra scoping to the CSS, please try the @next version to see if that solves your issues.

infime commented 3 years ago

@Ionaru works great, thanks!