search

Ionaru / easy-markdown-editor

EasyMDE: A simple, beautiful, and embeddable JavaScript Markdown editor. Delightful editing for beginners and experts alike. Features built-in autosaving and spell checking.
https://stackblitz.com/edit/easymde
MIT License
2.45k stars 319 forks source link

Spell check not working #276

Closed Fanvadar closed 3 years ago

Fanvadar commented 3 years ago

Describe the bug I can't seem to get any type of spell checking to work regardless of what configs I provide.

To Reproduce Steps to reproduce the behavior:

  1. Create a bare basic easyMDE: var easyMDE = new EasyMDE({element: document.getElementById('my-text-area'), spellChecker: true});
  2. This does not provide spell checking for me
  3. Even on all of the demos there is no spellchecking, even though it says spellChecker defaults to true.

Expected behavior Spellchecking

Version information

Jezdufourq commented 3 years ago

I have been meaning to see this fixed! Nice find.

Ionaru commented 3 years ago

This used to work a few releases ago, if someone can pinpoint when it broke then a fix should be easy.

Fanvadar commented 3 years ago

@Ionaru This bug was introduced in version 2.12.0 (2.11.0 works, 2.12.0 doesn't), almost certainly from this merge: 14a50293061f10d46483b9135f6f0fc401778664