search

Ionaru / easy-markdown-editor

EasyMDE: A simple, beautiful, and embeddable JavaScript Markdown editor. Delightful editing for beginners and experts alike. Features built-in autosaving and spell checking.
https://stackblitz.com/edit/easymde
MIT License
2.39k stars 316 forks source link

Apply toolbar top and bottom spacing using padding? #292

Closed sn3p closed 3 years ago

sn3p commented 3 years ago

Questions(s)

Is there any particular reason the top and bottom spacing inside the toolbar is done using :before and :after?

https://github.com/Ionaru/easy-markdown-editor/blob/0ff81e89a6ee37272ddfbcdf5084d6c961dc1669/src/css/easymde.css#L74-L87

And why the left and right spacing is added using padding?

https://github.com/Ionaru/easy-markdown-editor/blob/0ff81e89a6ee37272ddfbcdf5084d6c961dc1669/src/css/easymde.css#L66

Proposal

Would it make sense to just set the spacing using padding, and remove the :before and :after "hack"?

padding: 9px 10px;

This would make it easier to customize. Can make a PR but pitching this first :)

Ionaru commented 3 years ago

I'm not sure why this is done. The commit that introduced it is from waaaaaaaay before I made this fork: https://github.com/Ionaru/easy-markdown-editor/commit/de7f1a8d118a90f584727571d18b8b699fa1cc98. Feel free to make a PR for it :)

sn3p commented 3 years ago

@Ionaru PR is ready #293