search

Ionaru / easy-markdown-editor

EasyMDE: A simple, beautiful, and embeddable JavaScript Markdown editor. Delightful editing for beginners and experts alike. Features built-in autosaving and spell checking.
https://stackblitz.com/edit/easymde
MIT License
2.44k stars 318 forks source link

Side-by-side without fullscreen #434

Open vanillajonathan opened 2 years ago

vanillajonathan commented 2 years ago

Describe the bug If the editor is configured to have a side-by-side toolbar button but not the fullscreen button then pressing the button gets the user stuck in fullscreen mode.

To Reproduce Steps to reproduce the behavior:

  1. Configure editor with the side-by-side toolbar but without the fullscreen button.
  2. Click on the Side-by-side toolbar button.
  3. You're now stuck!

Expected behavior The side-by-side button should not put the editor into fullscreen mode, especially not if the fullscreen button is not present in the toolbar.

Version information

Additional context This can be set by:

const easyMDE = new EasyMDE({ sideBySideFullscreen: false });

Which I think:

  1. Should be the default setting.
  2. Or be autodetected if the fullscreen button is not in the toolbar.
Ionaru commented 2 years ago

Fullscreen is still available using F11 even if the button is not in the toolbar. The sideBySideFullscreen option is set to false by default because the editor is usually not big enough to show both the preview and the editor at the same time.

vanillajonathan commented 2 years ago

I can imagine F11 not being immediately obvious to a lot of users.

I don't know what is more common; users getting confused and feeling stuck in fullscreen mode, or users not having a big enough editor to show both the preview and the editor at the same time.