search

Ionaru / easy-markdown-editor

EasyMDE: A simple, beautiful, and embeddable JavaScript Markdown editor. Delightful editing for beginners and experts alike. Features built-in autosaving and spell checking.
https://stackblitz.com/edit/easymde
MIT License
2.38k stars 314 forks source link

Update Font Awesome to version 6 #445

Closed vanillajonathan closed 10 months ago

Ionaru commented 2 years ago

In my opinion, changing the default FontAwesome version is a breaking change. It could mess up custom toolbar buttons when not using icons that no longer exist or have changed.

Breaking changes I would like to reserve for the CodeMirror 6 rewrite.

vanillajonathan commented 2 years ago

Yes it could affect custom toolbar icons.

https://fontawesome.com/docs/web/setup/upgrade/upgrade-from-v4

gh-at-sqh commented 1 year ago

I'm using FA 6.4 and only had to add:

.editor-toolbar button {
     .fa {
        // No idea why EasyMDE uses fa for solids.
        font-family: #{$fas-font-name}; // FA-Solid
     }
     .fa.fa-image .fa.fa-eye {
         font-family: #{$fa-font-name}; // FA-Regular
     }
}

v4-shim.css from FA does not help. Was not needed in SimpleMDE.