search

Ionaru / easy-markdown-editor

EasyMDE: A simple, beautiful, and embeddable JavaScript Markdown editor. Delightful editing for beginners and experts alike. Features built-in autosaving and spell checking.
https://stackblitz.com/edit/easymde
MIT License
2.38k stars 314 forks source link

Add support for readonly attribute on textarea #446

Closed vanillajonathan closed 2 years ago

vanillajonathan commented 2 years ago

Closes #121

vanillajonathan commented 2 years ago

Please merge!

Ionaru commented 2 years ago

This could cause issues because we're changing the editor behaviour that people have been used to for years. New editor (#447) should definitely look at the readonly attribute, and probably others too.

vanillajonathan commented 2 years ago

Yeah, it could lead to a different behavior if someone were using the readonly attribute today, but I find it unlikely that anyone would use it without desiring that functionality.

The disabled attribute is another attribute that could be considered for the new editor.

I'll close this PR then.