search

Ionaru / easy-markdown-editor

EasyMDE: A simple, beautiful, and embeddable JavaScript Markdown editor. Delightful editing for beginners and experts alike. Features built-in autosaving and spell checking.
https://stackblitz.com/edit/easymde
MIT License
2.38k stars 314 forks source link

Use double curly braces instead of hash #460

Closed vanillajonathan closed 2 years ago

vanillajonathan commented 2 years ago

Use the more common double curly braces instead of hash for substitution

Ionaru commented 2 years ago

This would be a breaking change because the templates are part of the API. But I don't think this needs to be changed.

I think # was chosen to avoid conflicts with HTML template engines like Handlebars, but I am not sure of the exact reason, at the time I thought it was a reasonable choice.

Maybe @roipoussiere remembers? It was added in 3d1e33396f4c467a65039fe339a96f7c318b449b as part of #71 initially and merged in #101.

roipoussiere commented 2 years ago

I think I chosen the #xx# notation arbitrary, I was just looking at some chars that are likely not being included unintentionally in error messages.

vanillajonathan commented 2 years ago

Avoiding conflicts with HTML template engines like Handlebars sounds good, hence I'll close this PR.