search

Ionaru / easy-markdown-editor

EasyMDE: A simple, beautiful, and embeddable JavaScript Markdown editor. Delightful editing for beginners and experts alike. Features built-in autosaving and spell checking.
https://stackblitz.com/edit/easymde
MIT License
2.38k stars 314 forks source link

Remove class name from buttons #465

Closed vanillajonathan closed 10 months ago

vanillajonathan commented 2 years ago

The class names collide with built-in classes such as the "table" class in Bootstrap. This results in the buttons inheriting the style from Bootstrap (or other frameworks) that define classes with those names.

https://getbootstrap.com/docs/5.2/content/tables/

Ionaru commented 2 years ago

I agree this can be a problem, but it looks like removing the class name breaks more than you intended.

vanillajonathan commented 2 years ago

Removing the class from the button element broke the Cypress end-to-end tests, so I just prefixed the class with the mde- prefix instead.

I would have rather just removed the class from the button element altogether, but this works too and avoids any unintentional styling of the buttons.