search

Ionaru / easy-markdown-editor

EasyMDE: A simple, beautiful, and embeddable JavaScript Markdown editor. Delightful editing for beginners and experts alike. Features built-in autosaving and spell checking.
https://stackblitz.com/edit/easymde
MIT License
2.38k stars 314 forks source link

Type incorrect for `hideIcons` ? #487

Closed LoyalPotato closed 2 years ago

LoyalPotato commented 2 years ago

Shouldn't the type here be the same as showIcons?

https://github.com/Ionaru/easy-markdown-editor/blob/37561e44582eb8a55df4427115a020ef9364c366/types/easymde.d.ts#L186

Currently it just accepts a string array, but this way we don't have any auto complete for what icons we can hide.

Ionaru commented 2 years ago

Yes, you are correct.