Ionaru / easy-markdown-editor

EasyMDE: A simple, beautiful, and embeddable JavaScript Markdown editor. Delightful editing for beginners and experts alike. Features built-in autosaving and spell checking.
https://stackblitz.com/edit/easymde
MIT License
2.38k stars 314 forks source link

MacOS: conflicting keyboard shortcut to toggle preview (Cmd-P) #489

Open dminca opened 2 years ago

dminca commented 2 years ago

Describe the bug On MacOS, Cmd+P is the defacto shortcut for Print

To Reproduce Steps to reproduce the behavior:

  1. Type +P
  2. Print setting will open

Expected behavior Toggle preview

Screenshots image

Version information

Additional context Add any other context about the problem here.

Ionaru commented 2 years ago

Make sure you test this while you have are typing in the EasyMDE editor. On Windows the same shortcut is used for printing, but the editor shortcut has priority while the cursor is inside it.

If that doesn't work it means there's another difference between Safari and other browsers... 🙄

Ionaru commented 2 years ago

Test it on https://easy-markdown-editor.tk/, just to be safe.

dminca commented 2 years ago

Test it on https://easy-markdown-editor.tk/, just to be safe.

Thanks, it works perfectly fine there.

I've bumped into it whilst in Codeberg.org Issues editor which is using EasyMDE