`upload-image` is missing from `ToolbarButton` types

Ionaru / easy-markdown-editor

EasyMDE: A simple, beautiful, and embeddable JavaScript Markdown editor. Delightful editing for beginners and experts alike. Features built-in autosaving and spell checking.

https://stackblitz.com/edit/easymde

MIT License

2.32k stars 308 forks source link

`upload-image` is missing from `ToolbarButton` types #521

Closed p3yman closed 1 year ago

p3yman commented 1 year ago

Describe the bug upload-image is missing from ToolbarButton types and it cause error on TypeScript.

To Reproduce Steps to reproduce the behavior:

Try to use upload-image on a custom toolbar with type SimpleMDE.Options like:

const editorOptions: SimpleMDE.Options = {
  toolbar: [
    'bold',
    'italic',
    'strikethrough',
    'upload-image',
  ],
};

Expected behavior It should be included in easymde.d.ts

Version information

EasyMDE version: 2.18.0

borodean commented 1 year ago

PR: https://github.com/Ionaru/easy-markdown-editor/pull/520.

Ionaru commented 1 year ago

Fixed in https://github.com/Ionaru/easy-markdown-editor/pull/520