EasyMDE: A simple, beautiful, and embeddable JavaScript Markdown editor. Delightful editing for beginners and experts alike. Features built-in autosaving and spell checking.
Describe the bug
When using a maximum height in units other than pixels, the side-by-side preview pane is rendered incorrectly, typically ending up much shorter than it should be.
To Reproduce
Steps to reproduce the behavior:
Set maxHeight to a non-pixel value e.g. 40rem
Enable side-by-side without fullscreen
Expected behavior
The preview pane should be the same height as the editor pane.
Version information
OS: Windows
Browser: Chrome 122
EasyMDE version: 2.18.0
Additional context
This issue doesn't occur when using fullscreen mode.
Describe the bug When using a maximum height in units other than pixels, the side-by-side preview pane is rendered incorrectly, typically ending up much shorter than it should be.
To Reproduce Steps to reproduce the behavior:
maxHeightto a non-pixel value e.g.40remExpected behavior The preview pane should be the same height as the editor pane.
Version information
Additional context This issue doesn't occur when using fullscreen mode.
The trigger appears to be https://github.com/Ionaru/easy-markdown-editor/blob/master/src/js/easymde.js#L2555, as it's the only place where
options.maxHeightis wrapped inparseInt(), causing the unit to be discarded.