Ipuch / spartacus-shoulder-kinematic-dataset

Gathering all the litterature on shoulder kinematics, and scapulo-humeral rythm
GNU General Public License v3.0
6 stars 3 forks source link

Export of the risk in the csv #129

Closed ANaaim closed 6 months ago

ANaaim commented 7 months ago

Two elements in this PR :


This change is Reviewable

ANaaim commented 7 months ago

Probably some improvong to do on where are positioned the function.

I will continue with the export of the correct name of the degree of freedom

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 91.22807% with 5 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@74486ed). Click here to learn what that means.

Files Patch % Lines
spartacus/src/row_data.py 88.46% 3 Missing :warning:
spartacus/src/enums.py 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #129 +/- ## ======================================= Coverage ? 66.94% ======================================= Files ? 19 Lines ? 1180 Branches ? 0 ======================================= Hits ? 790 Misses ? 390 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ANaaim commented 7 months ago

DX pour la modif de code :

  1. Label
  2. Sense
  3. Origin
  4. Direction
  5. Euler sequence
  6. Translations CS
  7. TH joint angle
ANaaim commented 6 months ago

spartacus/src/row_data.py line 724 at r1 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…
Put this in a method `self.total_risk` ?

Would it be more coherent to put it in the deviation class ?

ANaaim commented 6 months ago

spartacus/src/row_data.py line 677 at r1 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…
Put this Joint class

Is joint_euler_angle_ISB_with adaptation_from_segment seems more a method of a row_data ==> You need to know both the distal and proximal segment coordinate system and the associated euler sequences to be able to determine if the euler sequences is ISB.

For quantify_joint_risk it should be moved in deviation I supposed (which are method for row_data as I understand it but we want them to be more readable)

ANaaim commented 6 months ago

spartacus/src/row_data.py line 634 at r1 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…
Use D notations D1, D2, D3, D4 ?

Everything in the Deviation class as suggested below

ANaaim commented 6 months ago

spartacus/src/row_data.py line 675 at r1 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…
In file deviation.py ```python class Deviation @staticmethod def euler_sequence(...) -> float return @staticmethod def label(...) -> float return ```

deviation.py file added with all the current risk calculated

ANaaim commented 6 months ago

spartacus/src/enums.py line 303 at r2 (raw file):


def isb_legend_rotation(joint_type: JointType) -> (str, str, str):

Where this should be ?

ANaaim commented 6 months ago

spartacus/src/row_data.py line 657 at r1 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…
extra documentation

Done

ANaaim commented 6 months ago

spartacus/src/row_data.py line 675 at r1 (raw file):

Previously, ANaaim (Alexandre Naaim) wrote…
deviation.py file added with all the current risk calculated

Risk was changed to confidence

ANaaim commented 6 months ago

spartacus/src/load.py line 145 at r2 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…
define types of entry while creating the dataframe.

Done

ANaaim commented 6 months ago

spartacus/src/load.py line 140 at r2 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…
biomechanical_dof

Done

ANaaim commented 6 months ago

image

ANaaim commented 6 months ago

As the image above show ==> new name seems ok ==> should be merge