search

Isilon / isilon_hadoop_tools

Tools for Using Hadoop with OneFS
https://pypi.org/project/isilon-hadoop-tools/
MIT License
14 stars 21 forks source link

Fix python-kadmin for testing #87

Closed tucked closed 3 years ago

tucked commented 3 years ago

https://github.com/Isilon/isilon_hadoop_tools/commit/8e187d3bf2dadfffe4a2b17bcc14f8d214940fc9 switched the python-kadmin dep from https://github.com/rjancewicz/python-kadmin/pull/59 to https://github.com/rjancewicz/python-kadmin/pull/66; however, we now hit https://github.com/rjancewicz/python-kadmin/issues/67. We need both PRs to fix this while maintaining py38 support, so I made https://github.com/tucked/python-kadmin/pull/1 to do that. This switches the dep to use that.

ro-ket commented 3 years ago

@tucked do you have test results? I can't eyeball the guid 😊

shirleylxie commented 3 years ago

The fix works. root@remotedev-sxie-rdu:/git/isilon_hadoop_tools# python3 -m tox -e py36 --devenv ./venv py36 create: /git/isilon_hadoop_tools/venv py36 installdeps: contextlib2 ~= 0.5.5, mock ~= 2.0.0, pytest ~= 4.3.0, pytest-cov ~= 2.6.1, pytest-randomly ~= 1.2.3, git+https://github.com/tucked/python-kadmin.git@fec2d339a64fe8912278f3ffc0b0d2f67ef8055f py36 develop-inst: /git/isilon_hadoop_tools py36 installed: atomicwrites==1.4.0,attrs==20.3.0,certifi==2020.12.5,chardet==4.0.0,contextlib2==0.5.5,coverage==5.5,future==0.18.2,idna==2.10,importlib-metadata==3.10.0,isi-sdk-7-2==0.2.11,isi-sdk-8-0==0.2.11,isi-sdk-8-0-1==0.2.11,isi-sdk-8-1-0==0.2.11,isi-sdk-8-1-1==0.2.11,isi-sdk-8-2-0==0.2.11,isi-sdk-8-2-1==0.2.11,isi-sdk-8-2-2==0.2.11,-e git+https://github.com/shirleylxie/isilon_hadoop_tools.git@238bf718e6eb439a49aca8d8d5ae29df95b176a6#egg=isilon_hadoop_tools,mock==2.0.0,more-itertools==8.7.0,pbr==5.5.1,pluggy==0.13.1,py==1.10.0,pytest==4.3.1,pytest-cov==2.6.1,pytest-randomly==1.2.3,python-dateutil==2.8.1,python-kadmin @ git+https://github.com/tucked/python-kadmin.git@fec2d339a64fe8912278f3ffc0b0d2f67ef8055f,requests==2.25.1,six==1.15.0,typing-extensions==3.7.4.3,urllib3==1.26.4,zipp==3.4.1

shirleylxie commented 3 years ago

root@remotedev-sxie-rdu:/git/isilon_hadoop_tools# cat tox.ini [tox]

minversion = 3.7.0

isolated_build = true

envlist = py{27,35,36,37,38}-urllib3{121,default}

[testenv]

deps = contextlib2 ~= 0.5.5 mock ~= 2.0.0 pytest ~= 4.3.0 pytest-cov ~= 2.6.1 pytest-randomly ~= 1.2.3 git+https://github.com/tucked/python-kadmin.git@fec2d339a64fe8912278f3ffc0b0d2f67ef8055f urllib3121: urllib3 ~= 1.21.1

tucked commented 3 years ago

@ro-ket In this case, I think we can probably use the Travis results...

And if I botched this, it's purely test code.