ItsJustMeChris / idTip-Community-Fork

Community maintained fork of @silverwind's WoW Addon idTip
BSD 2-Clause "Simplified" License
14 stars 5 forks source link

Error when hovering within achievements and TSM addon enabled #27

Closed Caerdon closed 1 year ago

Caerdon commented 1 year ago

Getting the following error when hovering over certain achievement criteria in the achievement frame and TSM and idTip are enabled:

Message: .../AddOns/idTip_CommunityFork/clients/dragonflight.lua:92: GetAchievementCriteriaInfo(achievementID, criteriaIndex [,countHidden]), criteria not found Time: Sat Nov 19 13:02:22 2022 Count: 2 Stack: .../AddOns/idTip_CommunityFork/clients/dragonflight.lua:92: GetAchievementCriteriaInfo(achievementID, criteriaIndex [,countHidden]), criteria not found [string "@Interface/AddOns/TradeSkillMaster/LibTSM/Service/ErrorHandler.lua"]:769: in function <...Ons/TradeSkillMaster/LibTSM/Service/ErrorHandler.lua:725>

string "=[C]": in function `GetAchievementCriteriaInfo' [string "@Interface/AddOns/idTip_CommunityFork/clients/dragonflight.lua"]:92: in function <.../AddOns/idTip_CommunityFork/clients/dragonflight.lua:86>

Locals: errMsg = ".../AddOns/idTip_CommunityFork/clients/dragonflight.lua:92: GetAchievementCriteriaInfo(achievementID, criteriaIndex [,countHidden]), criteria not found" isBugGrabber = nil tsmErrMsg = nil oldModule = nil private =

{ globalNameTranslation =
{ } FormatErrorMessageSection = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/ErrorHandler.lua:525 ErrorHandler = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/ErrorHandler.lua:134 origErrorHandler = defined @Interface/AddOns/WagoAnalytics/WagoAnalytics.lua:70 hitInternalError = false CreateErrorFrame = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/ErrorHandler.lua:544 num = 0 SanitizeString = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/ErrorHandler.lua:518 AddonBlockedHandler = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/ErrorHandler.lua:502 GetStackLevelInfo = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/ErrorHandler.lua:344 ParseLocals = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/ErrorHandler.lua:396 ignoreErrors = false errorReports =
{ } IsTSMAddon = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/ErrorHandler.lua:478 localLinesTemp =
{ } GetStackInfo = defined @Interface/AddOns/TradeSkillMaster/LibTSM/Service/ErrorHandler.lua:313 } MAX_STACK_DEPTH = 50 OLD_TSM_MODULES =
{ 1 = "TradeSkillMaster_Accounting" 2 = "TradeSkillMaster_AuctionDB" 3 = "TradeSkillMaster_Auctioning" 4 = "TradeSkillMaster_Crafting" 5 = "TradeSkillMaster_Destroying" 6 = "TradeSkillMaster_Mailing" 7 = "TradeSkillMaster_Shopping" 8 = "TradeSkillMaster_Vendoring" 9 = "TradeSkillMaster_Warehousing" }

ItsJustMeChris commented 1 year ago

Okay I think I finally figured out what was going on with achievements, I think it had to do with blizzard using a framepool and the hooks that were being placed were 'caching' the index of the criteria it was created for instead of representing the actual current criteria that's being hovered over. I believe this should be fixed in the next release.